Finall Pack + CI + solved shellcheck errors #1107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen0bit
changed the title
Merged
philclifford
requested changes
Apr 23, 2024
zen0bit
force-pushed
the
iffi
branch
8 times, most recently
from
a1d9863 to
495cae9
Compare
|
Something is broken, at least with check. The CI run shows a fail for latest minimal but currently we are fine. CI is missing the EDITION . This only happens for OpenIndiana and Siduction (search log for '--' ) Also there's something odd with the reporting of ubuntus - e.g. line 330 ... "FAIL - ... PASS" |
zen0bit
force-pushed
the
iffi
branch
15 times, most recently
from
9213639 to
de6f20f
Compare
zen0bit
force-pushed
the
iffi
branch
3 times, most recently
from
956924f to
c0f08b9
Compare
zen0bit
changed the title
zen0bit
changed the title
zen0bit
changed the title
zen0bit
force-pushed
the
iffi
branch
5 times, most recently
from
b191494 to
4e76db1
Compare
|
I'm closing this pull request because:
The only exception is the parallel testing changes, for which I welcome a pull request so it can be reviewed and tested in isolation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New UI finalization
tests:
Tests also save results to artifacts for later use (txt in zip)
see it in checks
PS: With parallelization we are under 10 minutes (from 30+)
Failed:
FAIL: arcolinux-v24.02.01-large https://mirror.accum.se/mirror/arcolinux.info/iso/v24.02.01/arcolinuxl-v24.02.01-x86_64.iso
FAIL: arcolinux-v24.02.01-small https://mirror.accum.se/mirror/arcolinux.info/iso/v24.02.01/arcolinuxs-v24.02.01-x86_64.iso
FAIL: arcolinux-v24.05.11-large https://mirror.accum.se/mirror/arcolinux.info/iso/v24.05.11/arcolinuxl-v24.05.11-x86_64.iso
FAIL: arcolinux-v24.05.11-small https://mirror.accum.se/mirror/arcolinux.info/iso/v24.05.11/arcolinuxs-v24.05.11-x86_64.iso
FAIL: blendos-v3-gnome https://mirror.ico277.xyz/blendos/gnome/blendos-v3-stable-gnome.iso
FAIL: fedora-39-Onyx
FAIL: fedora-39-Sericea
FAIL: rebornos-latest
Closes #1104 #1150 #1151 #1158
Help message: