Build all Windows targets when building in CI

quickjs-ng · Oct 8, 2024 · a51c77e · a51c77e
1 parent 2344d19
commit a51c77e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -204,10 +204,7 @@ jobs:
       - name: build
         run: |
           cmake -B build -DBUILD_EXAMPLES=ON -G "Visual Studio 17 2022" -A ${{matrix.arch}}
-          cmake --build build --config ${{matrix.buildType}} --target qjs_exe
-          cmake --build build --config ${{matrix.buildType}} --target function_source
-          cmake --build build --config ${{matrix.buildType}} --target fib
-          cmake --build build --config ${{matrix.buildType}} --target point
+          cmake --build build --config ${{matrix.buildType}}
       - name: stats
         run: |
           build\${{matrix.buildType}}\qjs.exe -qd
@@ -240,10 +237,7 @@ jobs:
       - name: build
         run: |
           cmake -B build -DBUILD_EXAMPLES=ON -G "Visual Studio 17 2022" -T ClangCL
-          cmake --build build --config ${{matrix.buildType}} --target qjs_exe
-          cmake --build build --config ${{matrix.buildType}} --target function_source
-          cmake --build build --config ${{matrix.buildType}} --target fib
-          cmake --build build --config ${{matrix.buildType}} --target point
+          cmake --build build --config ${{matrix.buildType}}
       - name: stats
         run: |
           build\${{matrix.buildType}}\qjs.exe -qd
@@ -280,10 +274,7 @@ jobs:
       - name: build
         run: |
           cmake -B build -DBUILD_EXAMPLES=ON -DCMAKE_BUILD_TYPE=${{matrix.buildType}} -G "Ninja"
-          cmake --build build --target qjs_exe
-          cmake --build build --target function_source
-          cmake --build build --target fib
-          cmake --build build --target point
+          cmake --build build
       - name: stats
         run: |
           build\qjs.exe -qd

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -284,7 +284,7 @@ endif()
 if(WIN32
 OR EMSCRIPTEN
 OR CMAKE_C_COMPILER_ID STREQUAL "TinyCC"
-OR CMAKE_C_COMPILER_ID STREQUAL "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_LESS 5)
+OR (CMAKE_C_COMPILER_ID STREQUAL "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_LESS 5))
     # Empty. run-test262 uses pthreads, sorry Windows users.
     # tcc and gcc 4.8 don't understand _Thread_local, whereas I
     # don't understand why people still use 4.8 in this day and age