Skip to content

Make initial shape hash table bigger #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

bnoordhuis
Copy link
Contributor

Even an empty script requires more than 16 entries in the hash table.

Before this commit, executing an empty script caused the hash table to resize two times. Now, it's the proper size from the start and not resized at all.

Even an empty script requires more than 16 entries in the hash table.

Before this commit, executing an empty script caused the hash table
to resize two times. Now, it's the proper size from the start and
not resized at all.
@bnoordhuis
Copy link
Contributor Author

@saghul gentle ping

Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opsie, sorry for the delay!

@bnoordhuis bnoordhuis merged commit 7238ee6 into quickjs-ng:master Jul 28, 2025
127 checks passed
@bnoordhuis bnoordhuis deleted the embiggen-shape-table branch July 28, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants