Drop support for "use math" #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I broke something and 262 found it! I'll take a look later. |
|
This one is ready @bnoordhuis ! |
bnoordhuis
approved these changes
Nov 6, 2023
| /* assume bigint mode: floats are parsed as integers if no decimal | ||
| point nor exponent */ | ||
| #define ATOD_MODE_BIGINT (1 << 9) | ||
| #define ATOD_MODE_UNUSED (1 << 9) |
There was a problem hiding this comment.
Suggested change
| #define ATOD_MODE_UNUSED (1 << 9) |
Or did you have a reason for keeping it around?
quickjs.c
Outdated
Comment on lines
10318
to
10319
| } else if ((atod_type == ATOD_TYPE_FLOAT64) && is_float && radix != 10) { | ||
| goto fail; |
There was a problem hiding this comment.
Suggested change
| } else if ((atod_type == ATOD_TYPE_FLOAT64) && is_float && radix != 10) { | |
| goto fail; | |
| } else if (atod_type == ATOD_TYPE_FLOAT64 && is_float && radix != 10) { | |
| goto fail; |
| goto fail; | ||
| case JS_TAG_FLOAT64: | ||
| case JS_TAG_BIG_FLOAT: | ||
| goto fail; | ||
| /* fall tru */ |
There was a problem hiding this comment.
Suggested change
| /* fall tru */ |
quickjs.c
Outdated
Comment on lines
21085
to
20786
| if (s->cur_func->js_mode & JS_MODE_MATH) | ||
| s->token.val = TOK_MATH_POW_ASSIGN; | ||
| else | ||
| s->token.val = TOK_XOR_ASSIGN; | ||
| s->token.val = TOK_XOR_ASSIGN; |
There was a problem hiding this comment.
I believe you can replace this block (the code inside the #ifdef CONFIG_BIGNUM) with just the #else case.
Sorry I got the impression you hadn't started :-/ |
|
Don't worry about it, it happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.