-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for "use strip" #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased. |
bnoordhuis
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Suggestion:
diff --git a/doc/quickjs.texi b/doc/quickjs.texi
index 9eb6354..ff14efc 100644
--- a/doc/quickjs.texi
+++ b/doc/quickjs.texi
@@ -286,8 +286,6 @@ ECMA402 (Internationalization API) is not supported.
@itemize
-@item The directive @code{"use strip"} indicates that the debug information (including the source code of the functions) should not be retained to save memory. As @code{"use strict"}, the directive can be global to a script or local to a function.
-
@item The first line of a script beginning with @code{#!} is ignored.
@end itemize
diff --git a/repl.js b/repl.js
index 484269e..0c0eb85 100644
--- a/repl.js
+++ b/repl.js
@@ -22,7 +22,6 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
-"use strip";
import * as std from "std";
import * as os from "os";
quickjs.c
Outdated
Comment on lines
32255
to
32261
printf("pass 2\n"); | ||
dump_byte_code(ctx, 2, fd->byte_code.buf, fd->byte_code.size, | ||
fd->args, fd->arg_count, fd->vars, fd->var_count, | ||
fd->closure_var, fd->closure_var_count, | ||
fd->cpool, fd->cpool_count, fd->source, fd->line_num, | ||
fd->label_slots, NULL); | ||
printf("\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
printf("pass 2\n"); | |
dump_byte_code(ctx, 2, fd->byte_code.buf, fd->byte_code.size, | |
fd->args, fd->arg_count, fd->vars, fd->var_count, | |
fd->closure_var, fd->closure_var_count, | |
fd->cpool, fd->cpool_count, fd->source, fd->line_num, | |
fd->label_slots, NULL); | |
printf("\n"); | |
printf("pass 2\n"); | |
dump_byte_code(ctx, 2, fd->byte_code.buf, fd->byte_code.size, | |
fd->args, fd->arg_count, fd->vars, fd->var_count, | |
fd->closure_var, fd->closure_var_count, | |
fd->cpool, fd->cpool_count, fd->source, fd->line_num, | |
fd->label_slots, NULL); | |
printf("\n"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #20