-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prototype inline cache #551
base: master
Are you sure you want to change the base?
Conversation
Nice! |
Thank you! Not sure I am qualified 😅 but I'll give it a try! |
@bnoordhuis Could you PTAL? LGTM in so far as I can read it and the tests pass 😅 |
I'll try to take a look over the weekend. |
I shall take a look over the week-end too. I have an alternate version on the back burner so let's see if @ErosZy approach is promissing... |
@bnoordhuis @saghul I've made some changes to the code based on the review; could you please take another look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good but I still have a few comments.
Any chance in this one being finished and included in the forthcoming release? Any performance bump is always great to have 🙂 |
Converting to draft while the feedback is addressed. It also needs a rebase... |
@saghul @bnoordhuis please check, thx. |
Tests are 💚 ! @bnoordhuis can you PTAL? |
I add prototype inline cache for basic get/set op, there are benchmark results: