Implement Iterator.prototype.take #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
commented
Nov 11, 2024
| @@ -40487,12 +40520,14 @@ static JSValue js_iterator_helper_next(JSContext *ctx, JSValue this_val, | |||
| JSIteratorHelperData *it; | |||
| JSValue ret; | |||
|
|
|||
| *pdone = FALSE; | |||
There was a problem hiding this comment.
This should fix the unitialized jump valgrind caught: https://github.com/quickjs-ng/quickjs/actions/runs/11786411039/job/32829640312
bnoordhuis
approved these changes
Nov 12, 2024
quickjs.c
Outdated
Comment on lines
40403
to
40405
| if (limit < 0) | ||
| fail: | ||
| return JS_ThrowRangeError(ctx, "must be positive"); |
There was a problem hiding this comment.
Suggested change
| if (limit < 0) | |
| fail: | |
| return JS_ThrowRangeError(ctx, "must be positive"); | |
| if (limit < 0) { | |
| fail: | |
| return JS_ThrowRangeError(ctx, "must be positive"); | |
| } |
(dominant style for this kind of thing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.