Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #685

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Documentation updates #685

merged 5 commits into from
Nov 15, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Nov 13, 2024

No description provided.

@saghul saghul requested a review from bnoordhuis November 13, 2024 22:42
docs/docs/cli.md Outdated Show resolved Hide resolved
# Differences with bellard/quickjs

This project aims to be a drop-in replacement for those already using QuickJS.
Minimal API changes might be necessary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably flesh those out. The only one that comes to mind is class ids may need tweaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The malloc function changes
  • SetOpaque can fail

Though those 2 are rare to see and maybe belong in advanced use cases...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my next pass I'll try and add some "migration" section.

docs/docs/diff.md Outdated Show resolved Hide resolved
docs/docs/diff.md Outdated Show resolved Hide resolved
@saghul saghul merged commit a7a6144 into master Nov 15, 2024
1 check passed
@saghul saghul deleted the docs-update branch November 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants