Removed some of the offending functions #754 #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Dec 15, 2024
chqrlie
reviewed
Dec 15, 2024
| @@ -41,7 +41,7 @@ | |||
| #pragma GCC visibility push(default) | |||
| #endif | |||
|
|
|||
| void pstrcpy(char *buf, int buf_size, const char *str) | |||
| void js__pstrcpy(char *buf, int buf_size, const char *str) | |||
There was a problem hiding this comment.
Out of curiosity, why 2 underscores?
There was a problem hiding this comment.
I saw several functions generic-sounding down there like js__hrtime_ns using two, so I went with that.
There was a problem hiding this comment.
It's a convention Ben and I carried on from libuv and started applying here too.
Double underscore for internal stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work to be done but let's start from these :).