Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bunDev2 #1028

Merged
merged 24 commits into from
Jan 16, 2024
Merged

bunDev2 #1028

merged 24 commits into from
Jan 16, 2024

Conversation

chalabi2
Copy link
Collaborator

1. Summary

Fixes # (issue)

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cd641a) 61.74% compared to head (0f8c928) 61.74%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   61.74%   61.74%           
=======================================
  Files         172      172           
  Lines       14125    14125           
=======================================
  Hits         8721     8721           
  Misses       4656     4656           
  Partials      748      748           
Flag Coverage Δ
unittests 61.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
});
});

const result = await tx(msgSubmitClaims, {

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable result.
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
web-ui/components/Assets/rewardsClaim.tsx Fixed Show fixed Hide fixed
@faddat
Copy link
Contributor

faddat commented Jan 14, 2024

If this offers improvements on what is in main let's get it merged/released imo.

Sorry -- I do not explicitly know the state of the code so it is hard for me to judge on that.

@chalabi2 chalabi2 marked this pull request as ready for review January 15, 2024 08:10
import { StdFee } from '@cosmjs/amino';
import { assets } from 'chain-registry';
import { cosmos } from 'interchain-query';
import { Grant, GenericAuthorization } from 'interchain-query/cosmos/authz/v1beta1/authz';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import Grant.
import { assets } from 'chain-registry';
import { cosmos } from 'interchain-query';
import { Grant, GenericAuthorization } from 'interchain-query/cosmos/authz/v1beta1/authz';
import { MsgSubmitClaim } from 'quicksilverjs/types/codegen/quicksilver/participationrewards/v1/messages';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import MsgSubmitClaim.
@@ -1,6 +1,6 @@
import { Box, Flex, Text, Icon, VStack, HStack, Heading, Spinner, Tooltip, Grid } from '@chakra-ui/react';
import { Progress, Flex, Text, VStack, HStack, Heading, Spinner, Tooltip, Grid, Center, Box } from '@chakra-ui/react';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import Center.
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit cced40c into main Jan 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants