Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: interchainstaking params #541

Closed
wants to merge 5 commits into from

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Aug 18, 2023

1. Summary

Fixes QCK-546

@aljo242 aljo242 changed the base branch from develop to unstable-v1.5 August 18, 2023 19:01
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #541 (4012b0e) into unstable-v1.5 (b630108) will decrease coverage by 0.14%.
Report is 3 commits behind head on unstable-v1.5.
The diff coverage is 32.91%.

Impacted file tree graph

@@                Coverage Diff                @@
##           unstable-v1.5     #541      +/-   ##
=================================================
- Coverage          53.08%   52.94%   -0.14%     
=================================================
  Files                187      189       +2     
  Lines              15312    15355      +43     
=================================================
+ Hits                8128     8130       +2     
- Misses              6517     6556      +39     
- Partials             667      669       +2     
Flag Coverage Δ
unittests 52.94% <32.91%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
x/airdrop/types/params_legacy.go 40.00% <ø> (ø)
x/claimsmanager/types/params_legacy.go 60.00% <ø> (ø)
x/interchainstaking/keeper/keeper.go 71.51% <ø> (+0.16%) ⬆️
x/interchainstaking/keeper/params_legacy.go 0.00% <0.00%> (ø)
x/interchainstaking/keeper/proposal_handler.go 0.00% <0.00%> (ø)
x/interchainstaking/types/keys.go 40.74% <ø> (ø)
x/interchainstaking/types/msgs.go 66.02% <0.00%> (-3.32%) ⬇️
x/interchainstaking/types/params_legacy.go 44.04% <ø> (ø)
x/mint/types/params_legacy.go 44.61% <ø> (ø)
x/participationrewards/types/params_legacy.go 60.00% <ø> (ø)
... and 6 more

@aljo242 aljo242 closed this Oct 18, 2023
@joe-bowman joe-bowman deleted the refactor/inerchainstaking-params branch December 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants