Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multierror library to monorepo #556

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 11, 2023

1. Summary

This PR adds https://github.com/ingenuity-build/multierror to the quicksilver monorepo under the util path.

2.Type of change

Monorepo refactor

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #556 (2fe768c) into develop (d9c52b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #556   +/-   ##
========================================
  Coverage    53.57%   53.57%           
========================================
  Files          185      185           
  Lines        14680    14680           
========================================
  Hits          7865     7865           
  Misses        6150     6150           
  Partials       665      665           
Flag Coverage Δ
unittests 53.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@faddat faddat requested review from ThanhNhann and removed request for cybertronprime and aljo242 September 13, 2023 10:20
@faddat faddat merged commit 8a14b02 into quicksilver-zone:develop Sep 13, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants