Skip to content

Commit

Permalink
Merge pull request #1542 from skurfer/warnings
Browse files Browse the repository at this point in the history
Warnings
  • Loading branch information
skurfer committed Jul 30, 2013
2 parents a4ccb5c + 5f2f620 commit 554495f
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 19 deletions.
7 changes: 2 additions & 5 deletions Quicksilver/Code-QuickStepCore/QSObject.h
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ typedef struct _QSObjectFlags {
- (void)setCache:(NSMutableDictionary *)aCache;
- (BOOL)isProxyObject;
- (QSObject *)resolvedObject;
// This private method is required for QSProxyObject.m
- (id)_safeObjectForType:(id)aKey;

@end

Expand Down Expand Up @@ -175,7 +177,6 @@ typedef struct _QSObjectFlags {
- (void)setIdentifier:(NSString *)newIdentifier;
- (NSString *)name;
- (void)setName:(NSString *)newName;
- (QSObject *)parent;
- (NSArray *)children;
- (void)setChildren:(NSArray *)newChildren;
- (NSArray *)altChildren;
Expand All @@ -198,10 +199,6 @@ typedef struct _QSObjectFlags {
- (NSTimeInterval)childrenLoadedDate;
- (void)setChildrenLoadedDate:(NSTimeInterval)newChildrenLoadedDate;


// This private method is required for QSProxyObject.m
- (id)_safeObjectForType:(id)aKey;

@end


Expand Down
24 changes: 12 additions & 12 deletions Quicksilver/Code-QuickStepCore/QSObject.m
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,18 @@ - (QSObject *)resolvedObject

@implementation QSObject (Hierarchy)

- (QSObject *)parent {
QSObject * parent = nil;

id handler = nil;
if (handler = [self handlerForSelector:@selector(parentOfObject:)])
parent = [handler parentOfObject:self];

if (!parent)
parent = [objectDictionary objectForKey:[meta objectForKey:kQSObjectParentID]];
return parent;
}

- (void)setParentID:(NSString *)parentID {
[self setObject:parentID forMeta:kQSObjectParentID];
}
Expand Down Expand Up @@ -709,18 +721,6 @@ - (void)setName:(NSString *)newName {
}
}

- (QSObject *)parent {
QSObject * parent = nil;

id handler = nil;
if (handler = [self handlerForSelector:@selector(parentOfObject:)])
parent = [handler parentOfObject:self];

if (!parent)
parent = [objectDictionary objectForKey:[meta objectForKey:kQSObjectParentID]];
return parent;
}

- (NSArray *)children {
if (!flags.childrenLoaded || ![self childrenValid])
[self loadChildren];
Expand Down
5 changes: 4 additions & 1 deletion Quicksilver/Code-QuickStepCore/QSRegistry.m
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,10 @@ - (id)getClassInstance:(NSString *)className {

- (NSMutableDictionary *)identifierBundles { return identifierBundles; }

+ (void)setObject:(id)object forKey:(NSString *)inTable:(NSString *)table {[[self sharedInstance] setObject:(id)object forKey:(NSString *)inTable:(NSString *)table];} ;
+ (void)setObject:(id)object forKey:(NSString *)key inTable:(NSString *)table {
[[self sharedInstance] setObject:object forKey:key inTable:table];
}

- (void)setObject:(id)object forKey:(NSString *)key inTable:(NSString *)table {
[[self tableNamed:table] setObject:object forKey:key];
}
Expand Down
2 changes: 1 addition & 1 deletion Quicksilver/SharedSupport/CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ This release requires 10.7+ and is 64-bit.
* Improved recognition of URLs and e-mail addresses (#1462, #1509, #1512, #1508, #1514)
* Fix the appearance of some hi-res images (#1518)
* Prevent duplicates in Recent Commands/command history (#1532)
* Internal improvements and bug fixes (#1468, #1475, #1479, #1505)
* Internal improvements and bug fixes (#1468, #1475, #1479, #1505, #1542)

### Changed ###

Expand Down

0 comments on commit 554495f

Please sign in to comment.