Skip to content

implement lenient parser #3131

implement lenient parser

implement lenient parser #3131

Triggered via pull request August 3, 2023 14:12
Status Success
Total duration 1h 4m 32s
Artifacts

coverage.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 warnings
very complex type used. Consider factoring parts into `type` definitions: query-grammar/src/query_grammar.rs#L691
warning: very complex type used. Consider factoring parts into `type` definitions --> query-grammar/src/query_grammar.rs:691:6 | 691 | ) -> JResult<&str, (Option<BinaryOperand>, Option<Occur>, Option<UserInputAst>)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
stripping a prefix manually: query-grammar/src/query_grammar.rs#L572
warning: stripping a prefix manually --> query-grammar/src/query_grammar.rs:572:17 | 572 | &i[1..], | ^^^^^^^ | note: the prefix was tested here --> query-grammar/src/query_grammar.rs:570:9 | 570 | if i.starts_with(']') { | ^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 570 ~ if let Some(<stripped>) = i.strip_prefix(']') { 571 | break Ok(( 572 ~ <stripped>, |
length comparison to zero: query-grammar/src/query_grammar.rs#L557
warning: length comparison to zero --> query-grammar/src/query_grammar.rs:557:12 | 557 | if i.len() == 0 { | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `i.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
stripping a prefix manually: query-grammar/src/query_grammar.rs#L272
warning: stripping a prefix manually --> query-grammar/src/query_grammar.rs:272:23 | 272 | break Ok((&i[1..], (UserInputAst::Clause(terms), errs))); | ^^^^^^^ | note: the prefix was tested here --> query-grammar/src/query_grammar.rs:271:9 | 271 | if i.starts_with(')') { | ^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip = note: `#[warn(clippy::manual_strip)]` on by default help: try using the `strip_prefix` method | 271 ~ if let Some(<stripped>) = i.strip_prefix(')') { 272 ~ break Ok((<stripped>, (UserInputAst::Clause(terms), errs))); |
length comparison to zero: query-grammar/src/query_grammar.rs#L267
warning: length comparison to zero --> query-grammar/src/query_grammar.rs:267:12 | 267 | if i.len() == 0 { | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `i.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default