Apply suggestions from code review

Co-authored-by: Paul Masurel <[email protected]>
quickwit-oss · Aug 28, 2023 · d772bf2 · d772bf2
1 parent cb27d77
commit d772bf2
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/src/aggregation/metric/average.rs b/src/aggregation/metric/average.rs
@@ -24,7 +24,7 @@ pub struct AverageAggregation {
     /// By default they will be ignored but it is also possible to treat them as if they had a
     /// value. Examples in JSON format:
     /// { "field": "my_numbers", "missing": "10.0" }
-    #[serde(skip_serializing_if = "Option::is_none", default)]
+    #[serde(default)]
     pub missing: Option<f64>,
 }
 

diff --git a/src/aggregation/metric/count.rs b/src/aggregation/metric/count.rs
@@ -24,7 +24,7 @@ pub struct CountAggregation {
     /// By default they will be ignored but it is also possible to treat them as if they had a
     /// value. Examples in JSON format:
     /// { "field": "my_numbers", "missing": "10.0" }
-    #[serde(skip_serializing_if = "Option::is_none", default)]
+    #[serde(default)]
     pub missing: Option<f64>,
 }
 

diff --git a/src/aggregation/metric/max.rs b/src/aggregation/metric/max.rs
@@ -24,7 +24,7 @@ pub struct MaxAggregation {
     /// By default they will be ignored but it is also possible to treat them as if they had a
     /// value. Examples in JSON format:
     /// { "field": "my_numbers", "missing": "10.0" }
-    #[serde(skip_serializing_if = "Option::is_none", default)]
+    #[serde(default)]
     pub missing: Option<f64>,
 }
 

diff --git a/src/aggregation/metric/min.rs b/src/aggregation/metric/min.rs
@@ -24,7 +24,7 @@ pub struct MinAggregation {
     /// By default they will be ignored but it is also possible to treat them as if they had a
     /// value. Examples in JSON format:
     /// { "field": "my_numbers", "missing": "10.0" }
-    #[serde(skip_serializing_if = "Option::is_none", default)]
+    #[serde(default)]
     pub missing: Option<f64>,
 }
 

diff --git a/src/aggregation/metric/stats.rs b/src/aggregation/metric/stats.rs
@@ -33,7 +33,7 @@ pub struct StatsAggregation {
     /// By default they will be ignored but it is also possible to treat them as if they had a
     /// value. Examples in JSON format:
     /// { "field": "my_numbers", "missing": "10.0" }
-    #[serde(skip_serializing_if = "Option::is_none", default)]
+    #[serde(default)]
     pub missing: Option<f64>,
 }
 

diff --git a/src/aggregation/metric/sum.rs b/src/aggregation/metric/sum.rs
@@ -24,7 +24,7 @@ pub struct SumAggregation {
     /// By default they will be ignored but it is also possible to treat them as if they had a
     /// value. Examples in JSON format:
     /// { "field": "my_numbers", "missing": "10.0" }
-    #[serde(skip_serializing_if = "Option::is_none", default)]
+    #[serde(default)]
     pub missing: Option<f64>,
 }