Fix testing on windows #2155
Merged
Fix testing on windows #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2155 +/- ##
==========================================
- Coverage 94.25% 94.24% -0.01%
==========================================
Files 320 320
Lines 62112 62112
==========================================
- Hits 58541 58540 -1
- Misses 3571 3572 +1 |
fulmicoton
approved these changes
Aug 27, 2023
|
Thank you! |
ethever
pushed a commit
to ethever/tantivy
that referenced
this pull request
Aug 30, 2023
* Fix missing trait imports * Fix building tests on windows * Revert other PR change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After manually doing this fix on several local instances when doing a fix or change, I finally broke and have just made this PR to fix testing tantivy on Windows.
The error is because of the deps used in the
benchdirectory aren't supported on Windows.