Update LogMergePolicy
to skip to a target number of documents
#2627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discord conversation:
https://discord.com/channels/908281611840282624/915785344396439552/1341705839668625468
This updated logic makes
LogMergePolicy
aim for a specific target number of documents, and opportunistically skip merge operations to reach that target document count.Pros:
max_docs_before_merge
)(target_segment_size * 2) - 2
Cons:
target_segment_size
total docs then it may get merged to a single segment and thus not parallelize well when searching