Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisional registrations, changing frame type to 0x24 #61

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Jan 23, 2024

Closes #60.

Copy link
Contributor

@DavidSchinazi DavidSchinazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change!

Copy link
Collaborator

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also choose the final transport parameter, and get it provisionally registered?

draft-ietf-quic-reliable-stream-reset.md Outdated Show resolved Hide resolved
kazuho and others added 2 commits January 23, 2024 11:23
…we want to have low latency handshake in protocols that use reliable resets)
@kazuho
Copy link
Member Author

kazuho commented Jan 23, 2024

@marten-seemann Makes sense. Switched to using 0x24 for the TP as well.

Copy link
Collaborator

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to get @LPardue's review on this PR, since we're now applying for provisional registration of the transport parameter as well.

@LPardue
Copy link
Member

LPardue commented Jan 23, 2024

I'm happy to hold off the TP a little longer.

While I certainly hope that there are no reasons that things need to substantially change, the TP is our way to control change ratcheting for this extension. Lets do WGLC with present TP and take a further view.

@DavidSchinazi
Copy link
Contributor

Oh I forgot to mention this before: if you change the value of the frame type you need to also change the transport parameter value. Though I'd change it to another 4-byte or 8-byte value as @LPardue suggests.

@LPardue
Copy link
Member

LPardue commented Jan 23, 2024

David's right, I missed that

@kazuho
Copy link
Member Author

kazuho commented Jan 23, 2024

@LPardue @DavidSchinazi Thank you for the comments.

Updated the PR so that:

  • TP ID is 8-byte,
  • TP ID specified is latest draft + 1,
  • TP ID is marked as provisional (with no intent to become permanent).

draft-ietf-quic-reliable-stream-reset.md Outdated Show resolved Hide resolved
@marten-seemann marten-seemann merged commit be369fe into quicwg:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please use a draft frame codepoint
4 participants