-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provisional registrations, changing frame type to 0x24 #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also choose the final transport parameter, and get it provisionally registered?
Co-authored-by: Marten Seemann <[email protected]>
…we want to have low latency handshake in protocols that use reliable resets)
@marten-seemann Makes sense. Switched to using 0x24 for the TP as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to get @LPardue's review on this PR, since we're now applying for provisional registration of the transport parameter as well.
I'm happy to hold off the TP a little longer. While I certainly hope that there are no reasons that things need to substantially change, the TP is our way to control change ratcheting for this extension. Lets do WGLC with present TP and take a further view. |
Oh I forgot to mention this before: if you change the value of the frame type you need to also change the transport parameter value. Though I'd change it to another 4-byte or 8-byte value as @LPardue suggests. |
David's right, I missed that |
@LPardue @DavidSchinazi Thank you for the comments. Updated the PR so that:
|
Co-authored-by: David Schinazi <[email protected]>
Closes #60.