NOT_ENOUGH_MEMORY from ramsurf after bad malloc #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a typo in the commit description: computatoin -> computation |
| #ifdef __SSE3__ | ||
| _MM_SET_FLUSH_ZERO_MODE(flush_mode); | ||
| #endif | ||
| return NOT_ENOUGH_MEMORY; |
There was a problem hiding this comment.
There is an obvious code duplication for the cleaning part here. The common way to avoid this is to use a goto end: that would perform the error checking before returning, or to nest tests. Either ways, duplicating the #ifdef looks bad to me.
There was a problem hiding this comment.
I thought about it but was not sure what would be the plocy about gotos. I do not like this code duplication solution either, it is a nightmare to maintain..
I'll change my proposal with the goto solution.
|
Maybe you should add a test case that triggers the OUT-OF-MEMORY scenario too? |
Return NOT_ENOUGH_MEMORY from ramsurf in case a malloc or a realloc fails during the computatoin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return NOT_ENOUGH_MEMORY from ramsurf in case a malloc or a realloc
fails during the computatoin.