fix(udp): make GRO (i.e. URO) optional on Windows, off by default #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7260987.
djc
reviewed
Dec 16, 2024
thomaseizinger
approved these changes
Dec 16, 2024
mxinden
force-pushed
the
optional-uro
branch
3 times, most recently
from
dcfd040 to
344382a
Compare
djc
approved these changes
Dec 16, 2024
mxinden
force-pushed
the
optional-uro
branch
from
344382a to
01d0a40
Compare
Ralith
requested changes
Dec 16, 2024
We have multiple bug reports for URO on Windows, including non-ARM. See: - quinn-rs#2041 - https://bugzilla.mozilla.org/show_bug.cgi?id=1916558 Instead of enabling GRO on Windows by default, this commit changes the default to off, adding a `set_gro` to optionally enable it.
mxinden
force-pushed
the
optional-uro
branch
from
01d0a40 to
8c6c855
Compare
Ralith
approved these changes
Dec 17, 2024
|
Thank you for the quick help here @djc @Ralith and @thomaseizinger! @djc @Ralith could either of you publish |
|
Yup, getting to it in ~15m! |
|
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Dec 19, 2024
…chain-reviewers `quinn-udp` `v0.5.9` contains another fix for Bug 1916558, disabling URO on Windows all together. See quinn-rs/quinn#2092. In addition `quinn-udp` `v0.5.9` unblocks Bug 1933904 through quinn-rs/quinn#2079. Differential Revision: https://phabricator.services.mozilla.com/D232475
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 19, 2024
…chain-reviewers `quinn-udp` `v0.5.9` contains another fix for Bug 1916558, disabling URO on Windows all together. See quinn-rs/quinn#2092. In addition `quinn-udp` `v0.5.9` unblocks Bug 1933904 through quinn-rs/quinn#2079. Differential Revision: https://phabricator.services.mozilla.com/D232475
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 1, 2025
…chain-reviewers `quinn-udp` `v0.5.9` contains another fix for Bug 1916558, disabling URO on Windows all together. See quinn-rs/quinn#2092. In addition `quinn-udp` `v0.5.9` unblocks Bug 1933904 through quinn-rs/quinn#2079. Differential Revision: https://phabricator.services.mozilla.com/D232475 UltraBlame original commit: 4cb4b627f721017c65b6705ebfdac2c8663f747f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 1, 2025
…chain-reviewers `quinn-udp` `v0.5.9` contains another fix for Bug 1916558, disabling URO on Windows all together. See quinn-rs/quinn#2092. In addition `quinn-udp` `v0.5.9` unblocks Bug 1933904 through quinn-rs/quinn#2079. Differential Revision: https://phabricator.services.mozilla.com/D232475 UltraBlame original commit: 4cb4b627f721017c65b6705ebfdac2c8663f747f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 1, 2025
…chain-reviewers `quinn-udp` `v0.5.9` contains another fix for Bug 1916558, disabling URO on Windows all together. See quinn-rs/quinn#2092. In addition `quinn-udp` `v0.5.9` unblocks Bug 1933904 through quinn-rs/quinn#2079. Differential Revision: https://phabricator.services.mozilla.com/D232475 UltraBlame original commit: 4cb4b627f721017c65b6705ebfdac2c8663f747f
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 2, 2025
…chain-reviewers `quinn-udp` `v0.5.9` contains another fix for Bug 1916558, disabling URO on Windows all together. See quinn-rs/quinn#2092. In addition `quinn-udp` `v0.5.9` unblocks Bug 1933904 through quinn-rs/quinn#2079. Differential Revision: https://phabricator.services.mozilla.com/D232475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple bug reports for GRO (i.e. URO) on Windows with no solution in sight.
While it previously seemed like this might be bound to Windows on ARM only, that assumption can no longer be made, see e.g. #2041 (comment) and Bugzilla comment. Thus our previous attempt (#2071) is not enough.
I suggest by default disabling GRO (i.e. URO) on all of Windows, with an advanced option for users to enable it via
UdpSocketState::set_gro(true).Users that control their hardware, i.e. know the hardware supports URO, can enable it.
Users that want to implement a heuristic, as e.g. suggested by @thomaseizinger in #2041 (comment), can enable or disable it programmatically.
Reverts #2071.
Tracked in #2041