Adding packet receipt timestamp collection into RecvMeta for linux #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
reviewed
Feb 10, 2025
| @@ -149,6 +157,11 @@ impl UdpSocketState { | |||
| )?; | |||
| } | |||
| } | |||
| #[cfg(target_os = "linux")] | |||
| { | |||
| // TODO: Should have a way to opt in to this. | |||
There was a problem hiding this comment.
Is there a drawback to having this enabled? cc @mxinden
| /// | ||
| /// Populated on platforms: Linux | ||
| #[cfg(not(wasm_browser))] | ||
| pub timestamp: Option<Duration>, |
There was a problem hiding this comment.
Document what this is relative to. If it's unspecified, document that.
| #[cfg(target_os = "linux")] | ||
| { | ||
| // TODO: Should have a way to opt in to this. | ||
| set_socket_option(&*io, libc::SOL_SOCKET, libc::SO_TIMESTAMP_NEW, OPTION_ON)?; |
There was a problem hiding this comment.
An error here probably shouldn't be fatal.
| @@ -83,6 +83,7 @@ impl<M: MsgHdr> Drop for Encoder<'_, M> { | |||
| /// `cmsg` must refer to a native cmsg containing a payload of type `T` | |||
| pub(crate) unsafe fn decode<T: Copy, C: CMsgHdr>(cmsg: &impl CMsgHdr) -> T { | |||
| assert!(mem::align_of::<T>() <= mem::align_of::<C>()); | |||
| // If you're hitting this, you might need to raise the CMSG_LEN constants | |||
There was a problem hiding this comment.
Would this be more helpful as an assert message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.