Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MLOP-2519): avoid configuring logger at lib level #393

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

lecardozo
Copy link
Contributor

Why? 📖

We should let the users handle logging configurations to avoid unwanted side effects.

What? 🔧

  • removing the butterfree.configs.logger module
  • replacing __logger references to logging.getLogger(__name__)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@lecardozo lecardozo added the bug Something isn't working label Jan 3, 2025
@lecardozo lecardozo requested a review from a team as a code owner January 3, 2025 18:11
Copy link

sonarqubecloud bot commented Jan 3, 2025

@lecardozo lecardozo changed the title fix: avoid configuring logger at lib level fix(MLOP-2519): avoid configuring logger at lib level Jan 3, 2025
Copy link
Contributor

@michellyrds michellyrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee!

@lecardozo lecardozo merged commit b7c7d48 into staging Jan 6, 2025
5 checks passed
@michellyrds michellyrds mentioned this pull request Jan 6, 2025
michellyrds added a commit that referenced this pull request Jan 7, 2025
## [1.4.6](https://github.com/quintoandar/butterfree/releases/tag/1.4.6)

### Fixed
* [MLOP-2519] avoid configuring logger at lib level
([#393](#393))
* Rollback to latest stable release
([#391](#391))

[MLOP-2519]:
https://quintoandar.atlassian.net/browse/MLOP-2519?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Mayara Moromisato <[email protected]>
Co-authored-by: hmeretti <[email protected]>
Co-authored-by: Henrique Camargo <[email protected]>
Co-authored-by: AlvaroMarquesAndrade <[email protected]>
Co-authored-by: Igor Gustavo Hoelscher <[email protected]>
Co-authored-by: Mayara Moromisato <[email protected]>
Co-authored-by: Felipe Victorino Caputo <[email protected]>
Co-authored-by: Rodrigo Martins de Oliveira <[email protected]>
Co-authored-by: Gabriel Brandão <[email protected]>
Co-authored-by: Jay Vala <[email protected]>
Co-authored-by: Lucas Fonseca <[email protected]>
Co-authored-by: Lucas Cardozo <[email protected]>
Co-authored-by: Ralph Rassweiler <[email protected]>
Co-authored-by: João Albuquerque <[email protected]>
Co-authored-by: Fernando Barbosa <[email protected]>
Co-authored-by: João Albuquerque <[email protected]>
Co-authored-by: Lucas Cardozo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants