Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AEFR-3588] Changing Slack with Gchat messages #13

Merged
merged 15 commits into from
Nov 16, 2023
Merged

[AEFR-3588] Changing Slack with Gchat messages #13

merged 15 commits into from
Nov 16, 2023

Conversation

kleberyuji
Copy link
Contributor

@kleberyuji kleberyuji commented Nov 8, 2023

Why? 📖

We have some messages sent to Slack and tomorrow we won't have access anymore. So we have to update the classes using the Gchat Webhook.

What? 🔧

  • GchatHelper.py created;
  • message.py creted;
  • base_validation_suites_executor updated;
  • validations_engine.py updated

Type of change 🗄️

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How everything was tested? 📏

It was tested by creating a whl lib file and installing it in a Databricks cluster. After this, I cleared a run in Airflow forno to check if the message was sent to the test channel in Gchat.

Captura de Tela 2023-11-14 às 10 05 14

Checklist 📝

  • I have added labels to distinguish the type of pull request.
  • My code follows the style guidelines of this project (docstrings, type hinting and linter compliance);
  • I have performed a self-review of my own code;
  • I have made corresponding changes to the documentation;
  • I have added tests that prove my fix is effective or that my feature works;
  • I have made sure that new and existing unit tests pass locally with my changes;

@kleberyuji kleberyuji added the enhancement New feature or request label Nov 8, 2023
@kleberyuji kleberyuji self-assigned this Nov 8, 2023
@kleberyuji kleberyuji changed the title Aefr 3588 [AEFR-3588] Changing Slack with Gchat messages Nov 8, 2023
@kleberyuji kleberyuji marked this pull request as ready for review November 14, 2023 12:58
Copy link

@dutrevis dutrevis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

Copy link

@dutrevis dutrevis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some removal of unnecessary f-strings

validations_engine/base_validation_suites_executor.py Outdated Show resolved Hide resolved
validations_engine/GchatHelper.py Outdated Show resolved Hide resolved
validations_engine/GchatHelper.py Outdated Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@dutrevis dutrevis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@kleberyuji kleberyuji merged commit 1f4ce2a into main Nov 16, 2023
5 checks passed
@kleberyuji kleberyuji deleted the AEFR-3588 branch November 16, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants