feat: WebEngage integration #557

VeenaYemmiganur · 2023-11-03T05:53:21Z

Description

Please include the summary of the change made. Please include the required context here. Please include the issue reference for the fix and the dependencies reference for the change.

Fixes # (issue-reference)

Dependencies # (dependency-issue-reference)

Documentation # (link to the corresponding documentation changes)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Case A
Test Case B

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Jeevan-Kishore · 2023-11-17T08:47:45Z

app/server/app.js


 export const app = createApp();

 upstreamQuintypeRoutes(app, {});
+const jsonParser = express.json();


unused variable

Jeevan-Kishore · 2023-11-17T08:49:12Z

app/server/handlers/render-layout.js

@@ -38,7 +38,7 @@ export async function renderLayout(res, params) {
  const placeholderDelay = parseInt(
    get(params.store.getState(), ["qt", "config", "publisher-attributes", "placeholder_delay"])
  );
-
+  const webengageLicenseCode = get(params.store.getState(), ["qt", "config", "webengage-config", "licenseCode"], "");


refactor params.store.getState() into a variable use

Jeevan-Kishore · 2023-11-17T08:50:28Z

app/server/webengage/createCampaign.js

+    const audienceCreationResponse = await (
+      await fetch(url, {
+        method: "POST",
+        body: JSON.stringify(platform === "push-notifications" ? appRequestPayload : webRequestPayload),


use function, take it out

Jeevan-Kishore · 2023-11-17T08:50:55Z

app/server/webengage/createCampaign.js

+    const campaignId = get(audienceCreationResponse, ["response", "data", "id"]);
+    return campaignId;


Suggested change

const campaignId = get(audienceCreationResponse, ["response", "data", "id"]);

return campaignId;

return get(audienceCreationResponse, ["response", "data", "id"]);

Jeevan-Kishore · 2023-11-17T08:51:45Z

app/server/webengage/createVariation.js

+      title,
+      description: message || subheadline,
+      sampling: 100,
+      icon: `https://afiles.webengage.com/${licenseCode}/97bd14d8-58fe-4303-be6c-9a1c2b99787f.jpg`,


remove hardcoded icon

Jeevan-Kishore · 2023-11-17T08:52:19Z

app/server/webengage/createVariation.js

+    },
+    {
+      sampling: 50,
+      layoutEId: "~20cc49c5",


Jeevan-Kishore · 2023-11-17T08:52:50Z

app/server/webengage/createVariation.js

+    await (
+      await fetch(url, {
+        method: "PUT",
+        body: JSON.stringify(platform === "push-notifications" ? appPushRequestPayload : webRequestPayload),


Jeevan-Kishore · 2023-11-17T08:53:29Z

app/server/webengage/webengage-handler.js

+  // Step 2: Schedule campaign  -- WHEN
+  await scheduleCampaign({
+    res,
+    url: `${BASE_URL}/api/v1/accounts/${licenseCode}/${WEB_PUSH_PLATFORM}/${campaignId}/targetingRule/schedule`,


use const / func

Jeevan-Kishore · 2023-11-17T08:54:14Z

app/server/webengage/webengage-handler.js

+  let targetMapping = [];
+  const targets = get(webhookContent, "targets", []);
+
+  targetMapping = targets.map((target) =>
+    targetHandlers[target]({ res, webhookContent, cdnName, sketchesHost, eventType })
+  );


Suggested change

let targetMapping = [];

const targets = get(webhookContent, "targets", []);

targetMapping = targets.map((target) =>

targetHandlers[target]({ res, webhookContent, cdnName, sketchesHost, eventType })

);

const targets = get(webhookContent, "targets", []);

const targetMapping = targets.map((target) =>

targetHandlers[target]({ res, webhookContent, cdnName, sketchesHost, eventType })

);

views/js/service-worker.ejs

phaneendraandukuri · 2023-11-17T09:43:41Z

app/server/webengage/createConversion.js

+    await (
+      await fetch(url, { method: "POST", body: JSON.stringify(requestPayload), headers: webengageHeaders })
+    ).json();


Suggested change

await (

await fetch(url, { method: "POST", body: JSON.stringify(requestPayload), headers: webengageHeaders })

).json();

const response = await fetch(url, { method: "POST", body: JSON.stringify(requestPayload), headers: webengageHeaders })

await response.json();

phaneendraandukuri · 2023-11-17T09:47:49Z

app/server/app.js

+import express from "express";
+import bodyParser from "body-parser";


can we move these lines to the top. just to keep all external library imports at one place

phaneendraandukuri · 2023-11-17T09:57:26Z

app/server/webengage/scheduleCampaign.js

+    await (
+      await fetch(url, { method: "POST", body: JSON.stringify(requestPayload), headers: webengageHeaders })
+    ).json();


wouldn't it be more readable if we take the fetch response in a variable?

Jeevan-Kishore · 2023-11-20T05:44:29Z

app/server/webengage/webengage-handler.js

+const getUrl = (url, platform, path) => {
+  return path === ""
+    ? `${url}/${licenseCode}/${platform}`
+    : path === "conversions"
+    ? `${url}/${licenseCode}/${path}`
+    : `${url}/${licenseCode}/${platform}/${path}`;
+};


Jeevan-Kishore · 2023-11-20T05:45:18Z

config/webengage-config.js

+  licenseCode: "11b564a4b",
+  apiKey: "1f30ed80-2618-46fc-a7dc-116be3984a85",


not in code

Veena2 added 9 commits November 2, 2023 17:33

Add. WE integration

2a15002

Add. Logs with Descriptoin

9666929

fix. variations issue

9d2c997

fix. variations issue 2 try

aee967e

fix. variations issue 2 try logs

111cf6e

fix. variations issue- 3 try

cac05cd

fix. variations issue- 4 try

7003745

fix. variations issue- 4 try

dff1fe0

add. conversion api

94ecd94

VeenaYemmiganur requested a review from Jeevan-Kishore November 3, 2023 05:53

Veena2 added 11 commits November 3, 2023 11:41

add. new project - refactor. licenseKey & api

c7820f0

revert api key

6f5afe2

disable onesignal

3093c24

refactor. layoutId in Variation API

64f12c5

refactor. conversion API

7c26f4b

refactor. remove logs

7e79a5e

refactor. remove logs

b8607ff

refactor. license key & api

272c6cb

refactor. test pn

03d98be

refactor. applyFrequencyCapping

0e2b081

refactor. baseUrl and Api Urls

bc3a02a

VeenaYemmiganur changed the title ~~New we integration~~ feat: WE integration Nov 17, 2023

VeenaYemmiganur changed the title ~~feat: WE integration~~ feat: WebEngage integration Nov 17, 2023

Jeevan-Kishore requested changes Nov 17, 2023

View reviewed changes

phaneendraandukuri reviewed Nov 17, 2023

View reviewed changes

Veena2 added 5 commits November 17, 2023 16:18

refactor. apply review comments

0e4522a

refactor. apply review comments 2

fcf9a85

refactor. apply review comments 2

9e3c40e

refactor. apply review comments 3

01c484c

refactor. apply review comments 3

f311222

Veena2 added 11 commits November 17, 2023 18:15

refactor. apply review comments 4

697a4e2

Debug. Add logs - review code

34cd185

Debug. Add logs - review code

1130df2

Debug. Add logs - review code

d15046e

Debug. Add logs - review code 2

7013354

Debug. Add logs - review code 2

1a1a8fe

Debug. Add logs - review code 3

eb4cc3a

Debug. Add logs - review code 4

e185fdf

Refactor. remove logs

053d94d

Refactor. add sw code

3a49a60

Revert. gitignore

03bd903

Jeevan-Kishore requested changes Nov 20, 2023

View reviewed changes

Veena2 added 2 commits November 20, 2023 11:26

Refactor. apply review change

94e7f76

Refactor. apply review changes

958de3f

Jeevan-Kishore approved these changes Nov 20, 2023

View reviewed changes

phaneendraandukuri approved these changes Nov 20, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: WebEngage integration #557

feat: WebEngage integration #557

VeenaYemmiganur commented Nov 3, 2023 •

edited

Loading

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

Jeevan-Kishore Nov 17, 2023

phaneendraandukuri Nov 17, 2023

phaneendraandukuri Nov 17, 2023

phaneendraandukuri Nov 17, 2023

Jeevan-Kishore Nov 20, 2023

Jeevan-Kishore Nov 20, 2023

		const campaignId = get(audienceCreationResponse, ["response", "data", "id"]);
		return campaignId;

	const campaignId = get(audienceCreationResponse, ["response", "data", "id"]);
	return campaignId;
	return get(audienceCreationResponse, ["response", "data", "id"]);

		import express from "express";
		import bodyParser from "body-parser";

		licenseCode: "11b564a4b",
		apiKey: "1f30ed80-2618-46fc-a7dc-116be3984a85",

feat: WebEngage integration #557

Are you sure you want to change the base?

feat: WebEngage integration #557

Conversation

VeenaYemmiganur commented Nov 3, 2023 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VeenaYemmiganur commented Nov 3, 2023 •

edited

Loading