Updates

quintype · Jul 17, 2024 · dfbbfb6 · dfbbfb6
1 parent 84d627c
commit dfbbfb6
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 17 deletions.
diff --git a/global.html b/global.html
@@ -1817,7 +1817,7 @@ <h5>Parameters:</h5>
         <p class="tag-source">
             <a href="src_structured-data_structured-data-tags.js.html" class="button">View Source</a>
             <span>
-                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line430">line 430</a>
+                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line440">line 440</a>
             </span>
         </p>
 
@@ -2245,7 +2245,7 @@ <h4 class="name" id="Organization">
         <p class="tag-source">
             <a href="src_structured-data_structured-data-tags.js.html" class="button">View Source</a>
             <span>
-                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line366">line 366</a>
+                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line376">line 376</a>
             </span>
         </p>
 
@@ -2629,7 +2629,7 @@ <h5 class="subsection-title">Properties:</h5>
         <p class="tag-source">
             <a href="src_structured-data_structured-data-tags.js.html" class="button">View Source</a>
             <span>
-                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line396">line 396</a>
+                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line406">line 406</a>
             </span>
         </p>
 
@@ -2708,7 +2708,7 @@ <h4 class="name" id="Website">
         <p class="tag-source">
             <a href="src_structured-data_structured-data-tags.js.html" class="button">View Source</a>
             <span>
-                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line380">line 380</a>
+                <a href="src_structured-data_structured-data-tags.js.html">src/structured-data/structured-data-tags.js</a>, <a href="src_structured-data_structured-data-tags.js.html#line390">line 390</a>
             </span>
         </p>
 

diff --git a/src_structured-data_structured-data-tags.js.html b/src_structured-data_structured-data-tags.js.html
@@ -358,23 +358,33 @@ <h1>src/structured-data/structured-data-tags.js</h1>
 }
 
 function getEmbedUrl(cards) {
-  let embedUrl = "";
+  const playerUrlMapping = {
+    "dailymotion-embed-script": "dailymotion-url",
+    "instagram": "instagram-url",
+    "facebook-video": "facebook-url",
+    "tweet": "tweet-url",
+    "vimeo-video": "vimeo-url",
+    "brightcove-video": "player-url"
+  };
 
-  // not using the return value of top level find
-  // coz we only need the embed url
-  // find is used for early exit
-  cards.find((card) => {
+  for (const card of cards) {
     const storyElements = get(card, ["story-elements"], []);
-    return storyElements.find((elem) => {
-      if (elem["embed-url"]) {
-        embedUrl = elem["embed-url"];
-        return true;
+    for (const elem of storyElements) {
+      if (elem.subtype &amp;&amp; elem.subtype in playerUrlMapping) {
+        const playerUrlField = playerUrlMapping[elem.subtype];
+        if (elem.metadata &amp;&amp; elem.metadata[playerUrlField]) {
+          return elem.metadata[playerUrlField];
+        }
+      };
+      if (elem.type === "youtube-video" &amp;&amp; elem.subtype === null) {
+        if (elem.url) {
+          return elem.url;
+        }
       }
-      return false;
-    });
-  });
+    }
+  }
 
-  return embedUrl;
+  return "";
 }
 
 function generateVideoArticleData(structuredData = {}, story = {}, publisherConfig = {}, timezone) {