Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiline cell issue #67 #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sampathbalivada
Copy link

@sampathbalivada sampathbalivada commented Apr 28, 2022

Fixes an issue where cells with multiple lines of data only return the first line. The fix joins all the lines in the cell with spaces and returns the string.

Problem

The original way is to choose the first value in the cell to ignore the \n\n that is returned by the API. When there are multiple lines of data this chooses the first string and returns the string thereby creating this issue.

Fix

The fix is to ignore the last string instead of selecting the first string. This way, cells with multiple lines will return the entire data.

Design decision taken

The fix will join multiple lines using whitespace. I understand this might not be the best way to do this and I am seeking some guidance in this case from the maintainers to ensure proper compatibility.

Fixes an issue where cells with multiple lines of data only return the first line. The fix joins all the lines in the cell with spaces and returns the string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant