feat(ActionMenu<Scan>): ds-437 add download report button

The button shall only be enabled when the scan is completed.
quipucords · Nov 6, 2024 · b7392ee · b7392ee
1 parent 7bdf3a3
commit b7392ee
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 4 deletions.
diff --git a/public/locales/en.json b/public/locales/en.json
@@ -173,6 +173,7 @@
     "label_satellite": "Satellite",
     "label_rhacs": "RHACS",
     "label_rescan": "Rescan",
+    "label_download": "Download",
     "label_scan": "Scan",
     "label_source": "Source",
     "label_source_other": "Sources",
@@ -276,6 +277,7 @@
     "description_scan-jobs_fetched_error": "Error displaying connection information. {{message}",
     "description_report_downloaded": "Report {{name}} downloaded successfully.",
     "description_report_downloaded_error": "Failed to download report {{name}}: {{message}}",
+    "description_report_downloaded_error_no_report": "The report doesn't exist.",
     "description_scan-report_start": "$t(toast-notifications.description_scan-report_play)",
     "title_add-source_hidden_error": "Error creating source {{ name }}. {{ message }}",
     "title_add-source_hidden_error_edit": "Error updating source {{ name }}. {{ message }}"

diff --git a/src/components/actionMenu/actionMenu.tsx b/src/components/actionMenu/actionMenu.tsx
@@ -11,7 +11,7 @@ import { EllipsisVIcon } from '@patternfly/react-icons';
 
 interface ActionMenuProps<T = unknown> {
   item: T;
-  actions: { label: string; onClick: (item: T) => void }[];
+  actions: { label: string; onClick: (item: T) => void; disabled?: boolean }[];
 }
 
 const ActionMenu = <T,>({ item, actions }: ActionMenuProps<T>) => {
@@ -43,6 +43,7 @@ const ActionMenu = <T,>({ item, actions }: ActionMenuProps<T>) => {
             onClick={() => {
               a.onClick(item);
             }}
+            isDisabled={a.disabled}
           >
             {a.label}
           </DropdownItem>

diff --git a/src/hooks/useScanApi.ts b/src/hooks/useScanApi.ts
@@ -343,8 +343,19 @@ const useDownloadReportApi = (onAddAlert: (alert: AlertProps) => void) => {
     [onAddAlert, t]
   );
 
+  const callbackErrorNoReport = useCallback(() => {
+    onAddAlert({
+      title: t('toast-notifications.description_report_downloaded_error_no_report'),
+      variant: 'danger'
+    });
+    return;
+  }, [onAddAlert, t]);
+
   const downloadReport = useCallback(
-    async (reportId: number) => {
+    async (reportId: number | undefined) => {
+      if (!reportId) {
+        return callbackErrorNoReport();
+      }
       let response;
       try {
         response = await apiCall(reportId);

diff --git a/src/views/scans/viewScansList.tsx b/src/views/scans/viewScansList.tsx
@@ -250,6 +250,13 @@ const ScansListView: React.FunctionComponent = () => {
                             setScanSelected(undefined);
                           });
                         }
+                      },
+                      {
+                        label: t('table.label', { context: 'download' }),
+                        disabled: scan.most_recent?.status === 'completed' ? false : true,
+                        onClick: () => {
+                          downloadReport(scan.most_recent?.report_id);
+                        }
                       }
                     ]}
                   />

diff --git a/tests/__snapshots__/code.test.ts.snap b/tests/__snapshots__/code.test.ts.snap
@@ -22,8 +22,8 @@ exports[`General code checks should only have specific console.[warn|log|info|er
   "hooks/useScanApi.ts:195:        console.log(missingScansMsg);",
   "hooks/useScanApi.ts:229:          console.error(error);",
   "hooks/useScanApi.ts:283:          console.error(error);",
-  "hooks/useScanApi.ts:356:          console.error(error);",
-  "hooks/useScanApi.ts:401:          console.error(error);",
+  "hooks/useScanApi.ts:367:          console.error(error);",
+  "hooks/useScanApi.ts:412:          console.error(error);",
   "hooks/useSourceApi.ts:63:          console.log(missingSourcesMsg);",
   "hooks/useSourceApi.ts:81:          console.log(missingSourcesMsg);",
   "hooks/useSourceApi.ts:127:          console.error(error);",