Fixit/main #16
Open
Fixit/main #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaskhan96
approved these changes
Nov 29, 2023
package.json
Outdated
| @@ -22,5 +21,9 @@ | |||
| "homepage": "https://github.com/quizizz/service-communication-wrapper#readme", | |||
| "dependencies": { | |||
| "axios": "^0.27.2" | |||
There was a problem hiding this comment.
let's also take this opportunity to upgrade axios to the latest version - 1.6.2
but we need to be careful and take care of any breaking type changes
https://github.com/axios/axios/blob/v1.x/CHANGELOG.md
arpitadlakha
force-pushed
the
fixit/main
branch
from
83079e7 to
c28a387
Compare
anaskhan96
reviewed
Dec 1, 2023
package.json
Outdated
| @@ -21,6 +28,19 @@ | |||
| }, | |||
| "homepage": "https://github.com/quizizz/service-communication-wrapper#readme", | |||
| "dependencies": { | |||
| "axios": "^0.27.2" | |||
| "axios": "^1.6.2", | |||
| "express": "^4.18.2", | |||
There was a problem hiding this comment.
we probably don't need express, couldn't find any usecase in the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.