fix: further avoid potential thread crashes #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `URL.query(percentEncoded:)` calls still cause Foundation `URL.host(percentEncoded:)` error, this bug seems to be fixed in a certain version of macos 14.4-15.0, so just increase the limit to 15.0.
quoid
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that it is not enough to only determine the existence of
URL.host. There are other cases that we are not aware of and continue to trigger FoundationURL.host(percentEncoded:)errors.It looks like we should completely abandon the new
URL.*(percentEncoded:)calls in the buggy versions and use the old properties that haven't been deprecated yet.This
Foundationbug should have been fixed somewhere between macOS 14.4-15.0 / iOS 17.0-18.0 versions.So let's just raise the limit to the versions with the known fix.