Add problem setup for cloud collapse at different metallicities #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWibking
requested changes
Aug 29, 2024
| break; | ||
| case 34: | ||
| numdens[n - 1] = userData_.primary_species_34; | ||
| break; |
There was a problem hiding this comment.
Can these be replaced with a macro?
There was a problem hiding this comment.
yeah, but you still need to call the macro 34 times, no? like the way we did it in microphysics...
6 tasks
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
### Description Now that we are going to have metal+dust chemistry, redefine the ifdef to CHEMISTRY ### Related issues Will be useful for #723 ### Checklist _Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an `x` inside the square brackets `[ ]` in the Markdown source below:_ - [x] I have added a description (see above). - [x] I have added a link to any related issues see (see above). - [x] I have read the [Contributing Guide](https://github.com/quokka-astro/quokka/blob/development/CONTRIBUTING.md). - [ ] I have added tests for any new physics that this PR adds to the code. - [x] I have tested this PR on my local computer and all tests pass. - [ ] I have manually triggered the GPU tests with the magic comment `/azp run`. - [] I have requested a reviewer for this PR. --------- Co-authored-by: Piyush Sharda <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
### Description Important updates to microphysics now enables using chemistry at all metallicities. ### Related issues Will be used in #723 ### Checklist _Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an `x` inside the square brackets `[ ]` in the Markdown source below:_ - [x] I have added a description (see above). - [x] I have added a link to any related issues see (see above). - [x] I have read the [Contributing Guide](https://github.com/quokka-astro/quokka/blob/development/CONTRIBUTING.md). - [ ] I have added tests for any new physics that this PR adds to the code. - [x] I have tested this PR on my local computer and all tests pass. - [x] I have manually triggered the GPU tests with the magic comment `/azp run`. - [x] I have requested a reviewer for this PR. Co-authored-by: Piyush Sharda <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add a test problem setup for simulating collapse of molecular cloud at different metallicities with on the fly (metals+dust) chemistry implemented in Microphysics. The chemistry network being used here is general and can be used for other ISM simulations as well. It does not contain cosmic rays and photochemistry; they will be added in a future PR.
Related issues
Will use AMReX-Astro/Microphysics#1642
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.