Restructure: define ComputeModelBasedKappaEAndKappaP #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
for more information, see https://pre-commit.ci
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BenWibking
reviewed
Oct 2, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BenWibking
approved these changes
Oct 3, 2024
markkrumholz
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another PR to restructure the code to increase readability.
This PR defines two functions:
ComputeModelDependentKappaEAndKappaPandComputeModelDependentKappaFAndDeltaTerms. They are used to replace the chunk of code that computeskappaEandkappaP, andkappaFbased on the opacity model, controlled by constant if.Related issues
This will simplify a large chunk of code in #766, where the same code is repeatedly used in all three energy exchange functions. I would like to merge in this PR before #766 .
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.