-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Compute emf #900
base: development
Are you sure you want to change the base?
[WIP] Compute emf #900
Conversation
for more information, see https://pre-commit.ci
… with different permutations can live in the same multifab
… with different permutations can live in the same multifab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The current sheet problem (https://www.astro.princeton.edu/~jstone/Athena/tests/current-sheet/current-sheet.html) runs, but produces very low densities, so I stopped it after the timestep got too small to continue (at about t ~ 1.9). It is stable with either arithmetic averaging scheme, but it has significant oscillations in the magnetic field (which is expected for arithmetic averaging): |
This is not very clear from the text, but the average transverse face-centered velocity Neco has currently implemented Equation 27 below. But I think it will make the code much simpler (and avoid the problematic method of reconstructing two directions in two different ways from Felker & Stone) to instead implement Equation 28 (https://ui.adsabs.harvard.edu/abs/2021JCoPh.42409748M/abstract): |
Ok, so it crashes in the AlfvenWave test if you turn on the HLL emf solver from LD04: |
for more information, see https://pre-commit.ci
It probably makes sense to use a much larger tolerance for the magnetic field L1 norm:
|
|
Description
TODO:
Related issues
Fixes #648.
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.