Gtad generating. BaseJob. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
requested changes
Jul 9, 2021
KitsuneRal
reviewed
Jul 12, 2021
KitsuneRal
reviewed
Jul 15, 2021
There was a problem hiding this comment.
Ok, I see a lot of progress - great job - but we have to cut this PR somewhere because it starts spinning out of control. It was originally aimed at getting the jobs working, and I totally get that Connection might be useful for that; but Room should really be spared for another PR. At this point it's worth spending a bit more effort at making the CI working.
KitsuneRal
approved these changes
Jul 16, 2021
This was referenced Jul 16, 2021
This was referenced Jul 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.