Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systray improvements #818

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Systray improvements #818

wants to merge 4 commits into from

Commits on Jul 22, 2023

  1. systray: Fix lack of initialization at startup

    @Tamaranch
    Tamaranch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    0b3ab6c View commit details
    Browse the repository at this point in the history

  2. systray: Use Room::notificationCount() instead of highlightCount() 

    The highlight count never seems to change, and the corresponding signal
never gets emitted. On the other hand, the notification count seems to
correspond well to the number of unread messages, and the correct signal
to connect to in order to get it seems to be Room::unreadStatsChanged().
    @Tamaranch
    Tamaranch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    d0b74ae View commit details
    Browse the repository at this point in the history

  3. systray: Do not emit notifications when the main window is active 

    It is natural not to disturb the user in this case, since his attention
is already focused on the application. In addition, it allows to filter
notifications when the number of unread messages decreases.
    @Tamaranch
    Tamaranch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    68b6fd1 View commit details
    Browse the repository at this point in the history

  4. systray: Notify user once between two activations of the main window 

    This cannot be done without leaving some indication to the user that a
notification has been issued in the past, which may anyway appear as a
lack even when notifications are issued with every new message.

This is achieved by changing the icon semi-permanently (until the next
activation of the main window), and by silently updating the tooltip
when new notifications are issued with the total number of unread
messages.

This icon change is included in the minimal notification mode, as it is
very non-intrusive.
    @Tamaranch
    Tamaranch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    9beac0c View commit details
    Browse the repository at this point in the history