-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AccountSettings: escape forward- and backslashes in MXIDs #846
Conversation
The test is screwed (and should really be a unit test, not a part of quotest) but the functionality seems to be working, as just tried in Quaternion. |
7a220b8
to
f82ebbf
Compare
This makes the account load fine, but it's not yet perfect: my test account with mxid
|
f82ebbf
to
a60dfa8
Compare
We could add unescaping in some other places; I'm just trying to stay conservative. Technically, it's possible to recover MXIDs even at the |
Looks like the Windows runner doesn't allow me to store settings in the registry?.. |
Okay, I found why this happens, |
It should unescape the user id back again after escaping it in the constructor.
8260ad6
to
03427c2
Compare
No idea what is happening on Windows CI: it successfully create a settings group for the account but fails to save anything inside the group. Given that it's failing even with "normal" MXIDs, I tend to blame the GitHub runner. Feel free to test it out, if it's fine, I'm merging it. |
Test both "normal" MXIDs and MXIDs with slashes; actually test reading into AccountSettings from the settings storage.
Otherwise QSettings fails to find/allocate its place in the Windows registry.
03427c2
to
203c6b2
Compare
I figured the problem on Windows in the end - |
Fixes #842.