Skip to content

🐛 Fix for changed API of uniseg's word_break #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

🐛 Fix for changed API of uniseg's word_break #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f8a8dd
🐛 Fix for changed API of uniseg's word_break
mikegerber Apr 16, 2025
badfa9c
⚙ GitHub Actions: Don't test on Python 3.8 anymore
mikegerber Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12", "3.13" ]
python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]

runs-on: "ubuntu-latest"

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
click
jinja2
lxml
uniseg >= 0.8.0
uniseg >= 0.9.1
numpy
colorama
MarkupSafe
Expand Down
6 changes: 3 additions & 3 deletions src/dinglehopper/word_error_rate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ def patch_word_break():
"""
old_word_break = uniseg.wordbreak.word_break

def new_word_break(c, index=0):
def new_word_break(c):
if 0xE000 <= ord(c) <= 0xF8FF: # Private Use Area
return uniseg.wordbreak.WordBreak.ALETTER
return uniseg.wordbreak.Word_Break.ALetter
else:
return old_word_break(c, index)
return old_word_break(c)

uniseg.wordbreak.word_break = new_word_break
global word_break_patched
Expand Down