Fix incorrect times
in time evolution solutions
#244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
times
of different time evolution solutions are basically obtained fromsol.t
.However, the length of
sol.t
actually depends on the keyword argumentsaveat
.To make it consistent with the docstrings, and also align with
QuTiP
, I putt_l
intop = (..., times = t_l, ...)
, and then pass it to different time evolution solutions withsol.prob.p.times
.After this PR, the type of
sol.times
are all the same asVector{<:Real}
for different time evolution solutions, and the length should be equal to the inputtlist
.