Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve random number generation on mcsolve and ssesolve #263

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

albertomercurio
Copy link
Member

Description

Reproducibility is a fundamental feature for Monte Carlo simulations and Stochastic Solvers. The previous implementation on mcsolve involved the explicit definition of the seeds vector as an argument. Now, instead, we just need to put the random number generator (together with some optional seed). Given this RNG, every trajectory is completely reproducible.

Moreover, I have also added this feature on ssesolve.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (8f64619) to head (3983afb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   93.33%   92.78%   -0.56%     
==========================================
  Files          31       31              
  Lines        2327     2328       +1     
==========================================
- Hits         2172     2160      -12     
- Misses        155      168      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit ddc98fc into qutip:main Oct 9, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants