Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lazy method to construct QobjEvo #282

Merged
merged 8 commits into from
Nov 2, 2024
Merged

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Nov 2, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributor Covenant Code of Conduct
  • Any code changes were done in a way that does not break public API
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Summary of this PR:

  • Add a lazy method to construct QobjEvo
  • make mcsolveProblem accept H_eff::AbstractQuantumObject to fix extra ScalarOperator for time-independent mcsolve. This breaks many things in dynamical solvers
  • improve runtests to make sure time-independent problems are MatrixOperator

Related issues or PRs

Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword close/closes/closed/fix/fixes/fixed/resolve/resolves/resolved followed by the issue id, e.g. fix #[id]
close #281

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (380d017) to head (d507107).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   94.16%   93.62%   -0.54%     
==========================================
  Files          32       32              
  Lines        2468     2463       -5     
==========================================
- Hits         2324     2306      -18     
- Misses        144      157      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit 54ded38 into qutip:main Nov 2, 2024
13 of 14 checks passed
@ytdHuang ytdHuang deleted the dev/QobjEvo branch November 3, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy way to create QobjEvo
2 participants