Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo reorg fix maturin develop #14

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Repo reorg fix maturin develop #14

merged 12 commits into from
Aug 15, 2023

Conversation

gnart33
Copy link
Contributor

@gnart33 gnart33 commented Aug 14, 2023

To resolve #13

@leolara
Copy link
Collaborator

leolara commented Aug 14, 2023

thanks @trangnv

@leolara
Copy link
Collaborator

leolara commented Aug 14, 2023

@trangnv is it possible to move the tutorials to their own folder tutorial ?

@gnart33
Copy link
Contributor Author

gnart33 commented Aug 14, 2023

Of course they (.py and .ipynb files) should be movable wherever we want.

features = ["pyo3/extension-module"]
python-source = "pychiquito"
python-source = "python"
module-name = "chiquito.rust_chiquito"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this makes rust_chiquito a sub module of package chiquito?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, an example using it here
In general, chiquito.rust_chiquito module has function listed here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes much more sense structure wise

@leolara leolara merged commit a61b2a8 into qwang98:main Aug 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo reorg and fix maturin develop
2 participants