Skip to content

Fetch dependencies using Ivy #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fetch dependencies using Ivy #1216

wants to merge 7 commits into from

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Nov 11, 2023

Removes dependant libraries from the source repository and fetches them from Maven Central using ivy.

@tresf
Copy link
Contributor Author

tresf commented Nov 11, 2023

It appears javafx.plaform="linux-monocle" is missing in Maven, which is breaking builds for Linux + Intel. I've inquired with Gluon, ticket SUPQZ-18.

@tresf
Copy link
Contributor Author

tresf commented Mar 13, 2024

It appears javafx.plaform="linux-monocle" is missing in Maven, which is breaking builds for Linux + Intel. I've inquired with Gluon, ticket SUPQZ-18.

Gluon has informed us that linux-monocle is being merged to mainline JavaFX as Headless instead. This is great news. We've provided Gluon with initial test results and they look promising. Once mainline has received the new Headless support, we can move to Ivy for good.

@tresf
Copy link
Contributor Author

tresf commented Dec 7, 2024

Once mainline has received the new Headless support, we can move to Ivy for good.

This has progressed since opening this PR: #1225 (comment). Since "Headless" requires Java 21 or higher, this PR must be merged with #1222 in order to test the headless libraries.

@tresf tresf changed the base branch from master to jdk21 December 7, 2024 19:02
Base automatically changed from jdk21 to master December 10, 2024 21:35
@tresf
Copy link
Contributor Author

tresf commented Dec 11, 2024

This PR is in surprisingly good shape... One outstanding issue is that the JavaFX version that we bundle is currently broken for vector (rasterize: false) prints. We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

javafx.version=24-headless+0-2024-12-02-101029

@tresf
Copy link
Contributor Author

tresf commented Mar 4, 2025

We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

The FX team has provided a patch for vector HTML prints, bumping the version and re-testing.

@tresf
Copy link
Contributor Author

tresf commented Mar 4, 2025

We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

The FX team has provided a patch for vector HTML prints, bumping the version and re-testing.

So vector prints are fixed, but I've found a bug with raster prints. From what I can tell this issue existed in the last FX snapshot version and I missed it. @akberenz and I spent an hour or so on it, but something with setZoom seems to cause the height on our rasterized-fitted tests to render way too tall. Our tests didn't catch this because the snapshot is actually succeeding, just at an unusual height. Something with the page height calculation is returning values that appear to be using zoom levels from previous snapshots.

@tresf
Copy link
Contributor Author

tresf commented Mar 5, 2025

We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

The FX team has provided a patch for vector HTML prints, bumping the version and re-testing.

So vector prints are fixed, but I've found a bug with raster prints. From what I can tell this issue existed in the last FX snapshot version and I missed it. @akberenz and I spent an hour or so on it, but something with setZoom seems to cause the height on our rasterized-fitted tests to render way too tall. Our tests didn't catch this because the snapshot is actually succeeding, just at an unusual height. Something with the page height calculation is returning values that appear to be using zoom levels from previous snapshots.

I was able to reproduce this bug on master branch, so this is no longer a blocker; testing is ready to continue.

@tresf
Copy link
Contributor Author

tresf commented Mar 25, 2025

Tested macOS, Windows 11, Ubuntu 24.04.

No regressions found. Now we wait for a JDK21 JavaFX "Headless" backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant