fix immediate parameter error in dbplyr::dbExecute #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR, plus tidyverse/dbplyr#1376, can solve the issue of #230, |
|
The CI fails because the new parameter is not documented. |
|
Thanks for your reminder. Not in office now, I will fix it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
dbplyr::dbExecutehas an additional parameterimmediate, which will further pass todbSendQuery, and lead to RMySQL broken.I added
...todbSendQuery.MySQLConnection, which will ignoreimmediateand any other irrelevant parameters, and make RMySQL in dbplyr alive again.Hope this PR could be accepted. Thanks.
https://github.com/tidyverse/dbplyr/blob/1e48cfaf795f9101792567bc68ce7d24a19db9d5/R/rows.R#L767