Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud masking for COPERNICUS/S2_SR_HARMONIZED #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukegre
Copy link

@lukegre lukegre commented May 21, 2024

Fix bug for S2_SR_HARMONIZED

Problem

ImageCollection COPERNICUS/S2_SR_HARMONIZED is not processed correctly, leading to problem in eemont when trying to use s2.maskClouds().

Fix

Hard comparison of platform (i.e., platform == "S3_SR") excludes S2_SR_HARMONIZED. Simply changed to a more lenient platform comparison (i.e., .startswith(S3_SR)).

Fixes the problem locally on my machine.

@lukegre lukegre closed this May 21, 2024
@lukegre
Copy link
Author

lukegre commented May 21, 2024

Already addressed by #52 but I'll leave it here since my changes do not include clouds+ which the dev team might not want to include immediately.

@lukegre lukegre reopened this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant