Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

href_topic() return NA if topic length > 1 #138

Merged
merged 1 commit into from
May 17, 2022
Merged

href_topic() return NA if topic length > 1 #138

merged 1 commit into from
May 17, 2022

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented May 16, 2022

If R interprets a BASH query with ? and * wildcards as an R expression, then
it will parse it as help as shown in #137

This fixes #137 by exiting href_topic() if the length of the topic is
greater than 1

@zkamvar zkamvar marked this pull request as ready for review May 16, 2022 18:21
@hadley hadley merged commit d0a7865 into r-lib:main May 17, 2022
@hadley
Copy link
Member

hadley commented May 17, 2022

Thanks!

@zkamvar zkamvar deleted the fix-137 branch June 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BASH globs accidentally interpeted as help queries
2 participants
@zkamvar @hadley