Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown #142

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add markdown #142

wants to merge 3 commits into from

Conversation

statnmap
Copy link

  • add gm_markdown_body() for a body in markdown
  • Markdown text is transformed into HTML using {markdown}
  • I updated doc and DESCRIPTION using attachment::att_amend_desc() as some deps in
    DESCRIPTION were not necessary anymore apparently

attachment::att_amend_desc(extra.suggests = "covr", pkg_ignore = "base") could be used after each dev modification.

statnmap added 3 commits July 22, 2020 14:31
- add `gm_markdown_body()` for a body in markdown
- Markdown text is transformed into HTML using {markdown}
- I updated doc and DESCRIPTION using `attachment::att_amend_desc()` as some deps in
DESCRIPTION were not necessary anymore apparently
@jimhester
Copy link
Member

Thanks for working on the PR. I think if we were going to add markdown support we should use the rmarkdown package rather than the markdown package.

Please remove the unrelated DESCRIPTION dependency changes.

@statnmap
Copy link
Author

statnmap commented Jul 28, 2020

I do not see in {rmarkdown} which function I can use to render a text fragment, other than creating a temporary external file to render with html_fragment() .
Did I miss something in the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants