Update compare_branches not to fail when one branch errors in some cases #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshesITR
reviewed
Apr 12, 2023
| lints <- as.data.frame(lint_dir(package, linters = linters, parse_settings = FALSE)), | ||
| { | ||
| # Don't fail out if one branch exhibits errors (e.g. if the new version fixes a known error) | ||
| lints <- tryCatch(lint_dir(package, linters = linters, parse_settings = FALSE), error = identity) |
There was a problem hiding this comment.
You are already within a withCallingHandlers() block so you could just add an error handler?
MichaelChirico
added
internals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erroring on
mainis a good way to suss out new logic errors, but erroring on the old branch is mostly an annoyance.