Use force() for better profiler output, r-prof/jointprof#34

r-lib · Jul 4, 2018 · 22046dd · 22046dd
1 parent 7e2a250
commit 22046dd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/R/extent.R b/R/extent.R
@@ -9,6 +9,7 @@
 #' get_extent(c("abc", "de"))
 #' get_extent("\u904b\u6c23")
 get_extent <- function(x) {
+  force(x)
   x <- fansi::strip_sgr(x, warn = FALSE)
   width <- utf8::utf8_width(x, encode = FALSE, utf8 = TRUE)
   is_na <- which(is.na(width))

diff --git a/R/styles.R b/R/styles.R
@@ -20,6 +20,7 @@ keep_empty <- function(fun) {
 #' @examples
 #' style_subtle("text")
 style_subtle <- keep_empty(function(x) {
+  force(x)
   if (isTRUE(getOption("pillar.subtle", TRUE))) {
     style_grey(0.6, x)
   } else {
@@ -44,6 +45,7 @@ style_subtle_num <- function(x, negative) {
 }
 
 style_hint <- keep_empty(function(x) {
+  force(x)
   if (isTRUE(getOption("pillar.subtle", TRUE))) {
     style_grey(0.8, x)
   } else {

diff --git a/R/type.R b/R/type.R
@@ -1,7 +1,9 @@
 MIN_PILLAR_WIDTH <- 5L
 
 style_type <- function(x) {
-  crayon::italic(style_subtle(x))
+  force(x)
+  x <- style_subtle(x)
+  crayon::italic(x)
 }
 
 #' Prepare a column type for formatting