Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on load when downstream dep is incompatible #853

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Oct 22, 2019

A user mentioned a forward compatibility issue between rlang 0.4.0 and dplyr 0.7.8: tidyverse/dplyr#4600.

As I'm about to release rlang 0.4.1, I'd like to experiment with a load-time warning to detect packages known to be forward-incompatible. Loading rlang with an old dplyr would give this warning:

Warning message:
As of rlang 0.4.0, dplyr must be at least version 0.8.0.
✖ dplyr 0.7.8 is too old for rlang 0.4.1.
ℹ Please update dplyr with `install.packages("dplyr")`.

On Windows platforms, we link to rstats-wtf/what-they-forgot#62 where the second comment provide a rough guide on proper updating of packages.

Warning message:
As of rlang 0.4.0, dplyr must be at least version 0.8.0.
✖ dplyr 0.7.8 is too old for rlang 0.4.1.
ℹ Please update dplyr to the latest version.
ℹ Updating packages on Windows requires precautions:
  <https://github.com/jennybc/what-they-forgot/issues/62>.

@lionel- lionel- requested a review from hadley October 22, 2019 16:43
@lionel- lionel- force-pushed the fix-downstream-dep branch from fc26d56 to e413578 Compare October 22, 2019 17:29
@hadley
Copy link
Member

hadley commented Oct 22, 2019

Doesn't purrr need this treatment too?

@lionel- lionel- force-pushed the fix-downstream-dep branch from e413578 to 111a0a2 Compare October 23, 2019 08:10
@lionel- lionel- merged commit e321b2f into r-lib:master Oct 23, 2019
@lionel- lionel- deleted the fix-downstream-dep branch October 23, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants