Skip to content

Fix two typos: overriden->overridden, an known->a known #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix two typos: overriden->overridden, an known->a known #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/namespace.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ roxy_tag_ns.roxy_tag_exportS3Method <- function(x, block, env) {

if (identical(x$val, "")) {
if (!inherits(obj, "s3method")) {
warn_roxy_tag(x, "must be used with an known S3 method")
warn_roxy_tag(x, "must be used with a known S3 method")
return()
}

Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/namespace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Code
. <- roc_proc_text(namespace_roclet(), block)
Message
x <text>:2: @exportS3Method must be used with an known S3 method.
x <text>:2: @exportS3Method must be used with a known S3 method.

# @exportS3Method can extract class from generic

Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-rd.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ test_that("package docs preserve existing aliases", {
expect_equal(out$get_value("alias"), c("empty-package", "a", "b"))
})

test_that("get correct alias even if user has overriden name", {
test_that("get correct alias even if user has overridden name", {
block <- "
#' Title
#' @name foo
Expand Down
Loading