Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds link to cli vignette on transition from ui_*() #2047

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Adds link to cli vignette on transition from ui_*() #2047

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0403c3b
Adds link to cli vignette on transition from ui_*()
cynthiahqy Aug 16, 2024
9b3ab98
Add link to cli conversion article in ui_* docs
cynthiahqy Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions R/ui-legacy.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
#'
#' usethis itself now uses cli internally for its UI, but these new functions
#' are not exported and presumably never will be. There is a developer-focused
#' article on the process of transitioning usethis's own UI to use cli (LINK
#' TO COME).
#' article on the process of transitioning usethis's own UI to use cli [here](https://cli.r-lib.org/articles/usethis-ui.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the intended link is to a usethis article:

https://usethis.r-lib.org/articles/ui-cli-conversion.html

When you update this PR can you also reword the sentence so that instead of having a "here" link, the hyperlink is attached to the article's title (Converting usethis's UI to use cli)? Thanks!


#' @details
#'
Expand Down
Loading